Fix: ui select option rendering #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the visibility issues on the `ui-select` in the price list modal. The selection is now rendered on the same line without breaks. Additionally, all translate filters have been converted to translate directives.
This commit adds "edit" to the pencil icon/button on the price list page to make it clearer what the action is.
This commit fixes all the ui-selects on the inventory group configuration pages. The labels are now displayed inline. It also updates the translate filter to translate directives where applicable.
The inventory groups page has now been updated with text on buttons so that users understand what the button does. Additionally, the link to the inventory registry has been beautified.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2017
1866: feat(patients): accept any document upload r=jniles This commit allows any document to be uploaded and attached to a patient. It also updates the document upload modal with the latest header crumb and translate directives. Closes #1823 1867: Fix: ui select option rendering r=jniles For some reason, a `ui-select` can only have a single `<span>` element within due to a miscreated CSS selector in the bootstrap css theme. Otherwise, the text is not labeled on the same line and is misaligned. This PR fixes those issues in the prices.html file and the inventory management page. It also uses the `translate` directive where applicable. Closes #993. Closes #1720. 1874: fix: allow navigation to settings after 403 error r=jniles This commit fixes a small bug does not a user log out after they have hit the 403 state. Closes #1862.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, a
ui-selectcan only have a single<span>element within due to a miscreated CSS selector in the bootstrap css theme. Otherwise, the text is not labeled on the same line and is misaligned. This PR fixes those issues in the prices.html file and the inventory management page.It also uses the
translatedirective where applicable.Closes #993. Closes #1720.