Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow navigation to settings after 403 error #1874

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jul 17, 2017

This commit fixes a small bug does not a user log out after they have
hit the 403 state.

Closes #1862.

This commit fixes a small bug does not a user log out after they have
hit the 403 state.

Closes Third-Culture-Software#1862.
@jniles jniles added the Bug Fix label Jul 17, 2017
@jniles jniles requested a review from sfount July 17, 2017 17:06
@jniles
Copy link
Collaborator Author

jniles commented Jul 18, 2017

bors r+

bors bot added a commit that referenced this pull request Jul 18, 2017
1866: feat(patients): accept any document upload r=jniles

This commit allows any document to be uploaded and attached to a
patient.  It also updates the document upload modal with the latest
header crumb and translate directives.

Closes #1823

1867: Fix: ui select option rendering r=jniles

For some reason, a `ui-select` can only have a single `<span>` element within due to a miscreated CSS selector in the bootstrap css theme.  Otherwise, the text is not labeled on the same line and is misaligned.  This PR fixes those issues in the prices.html file and the inventory management page.

It also uses the `translate` directive where applicable.

Closes #993.  Closes #1720.

1874: fix: allow navigation to settings after 403 error r=jniles

This commit fixes a small bug does not a user log out after they have
hit the 403 state.

Closes #1862.
@bors
Copy link
Contributor

bors bot commented Jul 18, 2017

Build succeeded

@bors bors bot merged commit 2ba3466 into Third-Culture-Software:master Jul 18, 2017
@jniles jniles deleted the fix-403-reroute-sink branch July 18, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: a 403 page captures all transitions to the settings page
1 participant