fix(filters): default filters are purple #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the default filters purple to increase legibility. The previous version had poor contrast for users without proper eye equipment - yellow on white. Here we use a dark purple to increase contrast and aid readability. Closes Third-Culture-Software#1949.
sfount
approved these changes
Aug 20, 2017
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 20, 2017
2019: fix(filters): default filters are purple r=sfount This commit makes the default filters purple to increase legibility. The previous version had poor contrast for users without proper eye equipment - yellow on white. Here we use a dark purple to increase contrast and aid readability. Closes #1949. <img width="201" alt="emphasizedefaultfiltersforlegibility" src="https://user-images.githubusercontent.com/896472/29485785-d66accbe-84cf-11e7-817b-b90039524928.PNG"> _Fig 1: New label emphasize class in action_ ------
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the default filters purple to increase legibility.
The previous version had poor contrast for users without proper eye
equipment - yellow on white. Here we use a dark purple to increase
contrast and aid readability.
Closes #1949.
_Fig 1: New label-emphasize class in action_Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the online review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!