fix(employee): rename grade_id to grade_uuid #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lomamech, could I get a review? |
jniles
force-pushed
the
chore-make-grade_id-into-grade_uuid
branch
from
cf2056f
to
13d67df
Compare
|
@jniles The Changes on this PR are not a problem, please update this PR is outdated |
|
@lomamech, thank you for the review! |
This commit renames the "grade_id" column to "grade_uuid" in reflection of it's underlying uuid representation. The three commands that were run were: ```sh find ./client/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' find ./server/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' find ./test/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' ``` Closes Third-Culture-Software#2208.
jniles
force-pushed
the
chore-make-grade_id-into-grade_uuid
branch
from
13d67df
to
af89a6d
Compare
|
@lomamech, I have updated the branch. If you type "bors r+", it should start the merge process. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 24, 2017
2216: fix(employee): rename grade_id to grade_uuid r=lomamech a=jniles This commit renames the "grade_id" column to "grade_uuid" in reflection of it's underlying uuid representation. The three commands that were run were: ```sh find ./client/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' find ./server/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' find ./test/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' ``` Partially addressed #342. Closes #2208.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the "grade_id" column to "grade_uuid" in reflection
of it's underlying uuid representation. The three commands that were run
were:
Partially addressed #342.
Closes #2208.