feat: automated backups w/ AWS S3 #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this requires an S3 Access Key. We'll have to figure out how to share it around for testing and deployment. |
jniles
force-pushed
the
feat-s3-backups
branch
from
9669eeb
to
6451add
Compare
|
It looks like the s3 client is old and unmaintained. There are a few issues related to the security vulnerability reported by snyk, see andrewrk/node-s3-client#194 for the most recent one. Fortunately, it looks like there is a fork that fixes the security issue andrewrk/node-s3-client#190 (comment) I'll switch over the dependency to this fork in a second. |
jniles
force-pushed
the
feat-s3-backups
branch
from
6451add
to
c7ec586
Compare
This commit adds automated backups using Amazon's S3 data storage as the online component. Backups consist of three separate components: 1) A mysqldump command to dump the data. 2) A compression step to deflate data size 3) An upload step to perform online backups. The lib/backups.js library encapsulates all three steps in promises, taking in the filename string at each step. It has some debug() calls scattered around to allow DEBUG=backups to show the internal workings of the script. Closes Third-Culture-Software#2284.
jniles
force-pushed
the
feat-s3-backups
branch
from
c7ec586
to
dc32826
Compare
|
Switched. Everything is green now 👍 |
This was referenced Nov 28, 2017
|
Weeee! bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 29, 2017
2305: feat: automated backups w/ AWS S3 r=jniles a=jniles This commit adds automated backups using Amazon's S3 data storage as the online component. Backups consist of three separate components: 1) A mysqldump command to dump the data. 2) A compression step to deflate data size 3) An upload step to perform online backups. The lib/backups.js library encapsulates all three steps in promises, taking in the filename string at each step. It has some debug() calls scattered around to allow DEBUG=backups to show the internal workings of the script. Closes #2284.  _Fig 1: What a backup looks like uploaded to AWS_
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds automated backups using Amazon's S3 data storage as the
online component. Backups consist of three separate components:
The lib/backups.js library encapsulates all three steps in promises,
taking in the filename string at each step. It has some debug() calls
scattered around to allow DEBUG=backups to show the internal workings of
the script.
Closes #2284.
Fig 1: What a backup looks like uploaded to AWS