Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lang #283

Merged
merged 15 commits into from
Apr 7, 2016
Merged

Lang #283

merged 15 commits into from
Apr 7, 2016

Conversation

lomamech
Copy link
Collaborator

@lomamech lomamech commented Apr 7, 2016

  • Updated interfaces with respect to the restructuring of file fr.json and en.json
  • Improve translation and fix test E2E for Service Unit

@sfount @DedrickEnc

@sfount
Copy link
Contributor

sfount commented Apr 7, 2016

This change LGTM. This will help reduce development collisions (re: translation files) a lot!

  • End to end tests pass
  • Integration tests pass
  • Unit tests pass

Very good re-factor 👍 @lomamech @DedrickEnc

@sfount sfount merged commit 66c30d3 into Third-Culture-Software:master Apr 7, 2016
@sfount
Copy link
Contributor

sfount commented Apr 7, 2016

This pull request forked and completed the work here #197. This can be closed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants