Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bhInfo): popovers made simple #545

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jun 28, 2016

This commit creates a bhInfo component that is simply a wrapper for popovers. Since this is a component, these popovers cannot have any knowledge of their parent scope. This component is ideal for informational popovers that only contain $translate filters.

The API is described in #525. For reference, here is an example usage:

<bh-info template="typePopover.tmpl.html" direction="right"></bh-info>

Closes #525.


Thank you for contributing!

Before submitting this pull request, please verify that you have:

  • Run your code through JSHint. Check out our styleguide.
  • Run integration tests.
  • Run end-to-end tests.
  • Accurately described the changes your are making in this pull request.

For a more detailed checklist, see the official review checklist that this PR will be evaluated against.

Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!

This commit creates a bhInfo component that is simply a wrapper for
popovers.  Since this is a component, these popovers cannot have any
knowledge of their parent scope.  This component is ideal for
informational popovers that only contain $translate filters.

Closes #525.
@sfount
Copy link
Contributor

sfount commented Jun 29, 2016

This make the module mark-up much cleaner! LGTM.

@sfount sfount merged commit 037d1d5 into Third-Culture-Software:master Jun 29, 2016
@jniles jniles deleted the feature-bh-info branch June 29, 2016 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants