Update stock value report #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbayopanda
reviewed
Aug 11, 2021
There was a problem hiding this comment.
This feature will be useful since there was many request for that, good job @jmcameron
For the first review, I have noticed that we can fix colspan and adds more information if it is possible :
- Add a column for value based on inventory selling price (price * quantity)
- Add sum in the footer of this new column
Columns can be :
- Code,
- Inventory Text,
- Quantity
- Inventory Price,
- Value for the price
- Stock Unit Cost
- Value for the stock unit cost
Names of these columns that I mentioned above don't matter
@jniles and I discussed this yesterday and we agree with you but decided that it would be better to add a new issue for that (which I have not done yet). @mbayopanda I encourage you to take your notes above and create a new issue. |
mbayopanda
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
The issue #5847 has been created, and this PR is LGTM 👍🏽
bors r+
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the inventory price to the Stock Value Report. Renames some internal variables to improve readability.
This also fixes a bug in the client-side form to create the Stock Value Report that was preventing it from remembering the "Exclude inventories with zero stock value" checkbox flag if the preview was cancelled and then a new preview was requested.
Closes #5408
TESTING