(refactor) billing services #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 27, 2016 12:02
This commit tells angular not to validate the form when the cancel button is pressed. Closes Third-Culture-Software#700.
This commit updates the HTML and JS for billing services to 2.x standards. In particular: 1. The ui-grid uses descriptive links instead of buttons 2. Notify catches HTTP errors 3. Cleaned up controller imports 4. Submit button conforms to standards
This commit improves the ui-router state management by implementing a more expressive URL syntax. It migrates all routes out off app.js and moves them to `billing_services.routes.js`. It also makes sure Notify catches delete errors, which apparently wasn't happening. Closes Third-Culture-Software#699.
This commit implements highlighting on ui-grid rows to draw attention to them. The color and duration can be edited in the bhima-bootstrap.less files. For the moment, it flashes informational blue for 1.5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors billing services to bring them up to date with current standards. It completely restructures the URL to be compliant with the latest
ui-routerstandards (this was the first ui-router page, so its state-based routing was pretty amateur).Notable Changes:
Notifyfor errors and success messages.:idwhen provided.billing_service.routes.jsand update to latest standard.Closes #699. Closes #700.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!