Confirm dialog modal implementation #763
Conversation
|
@jniles could you review this PR |
|
@mbayopanda, the text "Veuillez saisir 'Le nom du project' pour confirmer" makes me think that I should type I would either remove the quotes (Veuillez saisir le nom du project pour confirmer) or actually template in the project name (Veuillez saisir "Project Pax Clinique" pour confirmer). Does that make sense? |
|
@jniles you're right. |
mbayopanda
force-pushed
the
feature-confirm-dialog
branch
from
728db89
to
5423dc3
Compare
| "PLEASE_TYPE_TEXT" : "Please type in the %ELEMENT% name to confirm", | ||
| "CANNOT_UNDONE_ACTION" : "This action CANNOT BE REVERSED, this action will be permanent. You must be sure that you want to do this action", | ||
| "NO_CORRESPONDANCY" : "No correspondancy found for ", | ||
| "PLEASE_TYPE_TEXT" : "Please type %ELEMENT% to confirm", |
There was a problem hiding this comment.
For future reference, angular-translate provides variable substitution so that you do not have to do this manually. Documentation. An interesting PR related to this.
Since we've been using this style long term, I don't mind merging this PR. But if possible, it would be nice to move to angular-translate's way of putting parameters into our translations. I made an issue about it a long time ago: #408.
|
|
||
| Modal.openConfirmDeletion(request) | ||
| Modal.openConfirmDialog(request) |
There was a problem hiding this comment.
Confirm Dialog is much better name 👍.
| var request = { pattern: pattern, elementName: 'document'}; | ||
| var request = { | ||
| pattern: pattern, | ||
| patternName: 'FORM.PATTERNS.DOCUMENT_NAME' |
There was a problem hiding this comment.
patternName is a much better name 👍
| @@ -170,10 +170,10 @@ function EnterpriseController($translate, Enterprises, Currencies, Accounts, uti | |||
| function deleteProject(id, pattern) { | |||
| var params = { | |||
| pattern: pattern, | |||
| elementName: $translate.instant('FORM.LABELS.PROJECT') | |||
| patternName: 'FORM.PATTERNS.PROJECT_NAME' | |||
There was a problem hiding this comment.
I'm glad the $translate call has finally been moved into the modal. This is a nice improvement.
| "PLEASE_TYPE_TEXT" : "Please type in the %ELEMENT% name to confirm", | ||
| "CANNOT_UNDONE_ACTION" : "This action CANNOT BE REVERSED, this action will be permanent. You must be sure that you want to do this action", | ||
| "NO_CORRESPONDANCY" : "No correspondancy found for ", | ||
| "PLEASE_TYPE_TEXT" : "Please type {{value}} to confirm", |
This PR :
confirmDeletionmodal and replace it with theconfirmDialogmodalclose #759