Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Cashbox Management #780

Closed
8 of 9 tasks
jniles opened this issue Oct 5, 2016 · 1 comment
Closed
8 of 9 tasks

(refactor) Cashbox Management #780

jniles opened this issue Oct 5, 2016 · 1 comment
Assignees
@jniles @sfount
Labels
Refactor

Comments

@jniles
Copy link
Collaborator

jniles commented Oct 5, 2016 •
edited
Loading

The cashbox management page is terribly out of date. Here is an incomplete list of issues with it.

  • Remove the unused utility bar.
  • Does not use $state-based routing. The states should be broken down like this:
    • cashboxes/create should open to the create form.
    • cashboxes/:uuid/update should open the update form and load the cashbox matching :uuid.
    • cashboxes/:uuid/currency/:id should open the update form for cashbox :uuid, and place the currency modal on top of it, open to currency id :did
      (Linking the URL/ history for updating the currency of an individual cashbox would require nested state that we have not yet developed or used
  • Submit and cancel buttons should conform to standards.
  • Accounts should be ui-selects. They were missed in (refactor) account uiSelects #745.
  • Delete should use the confirm modal dialog (see Confirm dialog modal implementation #763).
  • Bug The cashbox does not register auxiliary versus primary on the edit page properly.
@jniles jniles added the Refactor label Oct 5, 2016
@jniles jniles added this to the Finance Implementation milestone Oct 5, 2016
@sfount sfount self-assigned this Oct 20, 2016
@sfount sfount mentioned this issue Oct 27, 2016
Merged
4 tasks
@jniles
Copy link
Collaborator Author

jniles commented Nov 11, 2016

I'll look into this today.

jniles pushed a commit to jniles/bhima that referenced this issue Nov 11, 2016
refactor(cashboxes): migrate to account uiSelects
d957830 
This commit refactors the cashboxes currency modal to use uiSelects for
the account selection instead of the original HTML select elements.  It
also disables accounts with TITLE account ids from selection.

This is the last piece of refactor for the cashboxes page.

Closes IMA-WorldHealth#780.
@jniles jniles mentioned this issue Nov 11, 2016
Merged
4 tasks
sfount pushed a commit that referenced this issue Nov 14, 2016
@sfount
refactor(cashboxes): migrate to account uiSelects
f86890b 
This commit refactors the cashboxes currency modal to use uiSelects for
the account selection instead of the original HTML select elements.  It
also disables accounts with TITLE account ids from selection.

This is the last piece of refactor for the cashboxes page.

Closes #780.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

@sfount sfount

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount