Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique IDs to items as a new column #30

Closed
asoskic opened this issue Jun 24, 2022 · 5 comments
Closed

Add unique IDs to items as a new column #30

asoskic opened this issue Jun 24, 2022 · 5 comments

Comments

@asoskic
Copy link
Collaborator

asoskic commented Jun 24, 2022

No description provided.

@asoskic
Copy link
Collaborator Author

asoskic commented Sep 26, 2022

Two questions first, to see with Dejan:

  1. is this something we want to have from Version 1
  2. what is the best way to create these IDs given that their order might change over time, or they may be discontinued

@asoskic
Copy link
Collaborator Author

asoskic commented Sep 26, 2022

To be discussed with Dejan, suggestion from Lazar - this should be created by the web-app, and not manually by people who create the spreadsheet. Suggestion for adding and editing new questions to allow for compatibility between versions - question editing happens in an admin panel, so that even the person editing the template contents does not have control over the unique ID and it is crystal clear when a new question is added or when an existing one is edited (or even discontinued, when the order is changed etc).

@asoskic
Copy link
Collaborator Author

asoskic commented Oct 5, 2022

This will be part of the discussion on compatibility (see also issue #26)

@asoskic
Copy link
Collaborator Author

asoskic commented Aug 24, 2023

@Remi-Gau this is an old discussion of the issue you opened and I marked as a duplicate.

After talking to @dpajicns this makes sense:

We should not change item_pref_label, and we should not change question text and answer options/type in the way that we have practically a new question under an old name or in a way that causes a problem with loading an old template into the web-app. Instead, only superficial changes such as typos and wording should be done with keeping the same item_pref_label. If we want to make a more substantial change, we should exclude the old question by making the include value 0, and we should create a new question with a new item_pref_label. This way we have a history record of old items and their item_pref_label-s that should not be used.

@asoskic
Copy link
Collaborator Author

asoskic commented Jan 23, 2024

This has been resolved by using item_pref_label as variable name, which should never be changed, and variable names are preserved by excluding new questions by setting the column include to 0, rather than deleting the question altogether. Doing this will remove the question from the template while preserving information about it and it will also automatically set the column item order to exlcude the question from the ordering.

@asoskic asoskic closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant