-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify first module wrap-up quiz to not need a SimpleImputer #361
Comments
We probably need to create a notebook with a title similar to "Illustration of a rich pipeline: handling missing values" |
I think the consensus at the time we discussed it (probably @GaelVaroquaux was not involved though I don't remember for sure) was not to add more content to the module 1 and do the simplest thing which was removing missing values with a few lines of pandas. Whether we should talk about imputing missing data somewhere and where to put it, I have to say I don't know. |
I think the consensus at the time we discussed it (probably @GaelVaroquaux was
not involved though I don't remember for sure) was not to add more content to
the module 1 and do the simplest thing which was removing missing values with a
few lines of pandas.
I would even store a simplified dataset that does not have these misssing
values, to avoid having to discuss this.
|
Good point, we are using a local CSV file so this is probably the simplest thing to do. This would be nice to add a note about this in |
There are some features such as 'Alley', 'PoolQC' , 'Fence' and 'MiscFeature' that have more than 500 na values. Erasing columns means that we will have to adjust the rest of the questions and hints accordingly. What do you think? |
We can directly erase it in the CSV this way the quiz instructions are a bit simpler (and we don't have to explain that we are dropping NaNs or why we are doing it).
Good points I guess that means we may need to change quite a lot of the quiz with this change (for example the correction will change since we don't need a |
So we agreed to:
|
https://mooc-forums.inria.fr/moocsl/t/m1-wrap-up-quiz-q5-simpleimputer-question/2535
There were some feed-back from the beta that it was hard to answer the question because it was not clear that a pipeline could be nested. We tried to give more guidance in the question:
Proposed solutions:
The text was updated successfully, but these errors were encountered: