Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: refactor: SizeReplaceableByIsEmpty #4845

Merged
merged 4 commits into from
Aug 20, 2022
Merged

review: refactor: SizeReplaceableByIsEmpty #4845

merged 4 commits into from
Aug 20, 2022

Conversation

MartinWitt
Copy link
Collaborator

@MartinWitt MartinWitt commented Aug 18, 2022 •
edited
Loading

Changelog

The following bad smells are refactored:

SizeReplaceableByIsEmpty

Checking if a string is empty should be done by String#isEmpty instead of String.length==0

The following has changed in the code:

SizeReplaceableByIsEmpty

  • Replaced string.length empty check with string.isEmpty

@MartinWitt MartinWitt marked this pull request as ready for review August 18, 2022 16:24
@MartinWitt MartinWitt changed the title refactor: SizeReplaceableByIsEmpty review: refactor: SizeReplaceableByIsEmpty Aug 18, 2022
slarse
slarse approved these changes Aug 20, 2022
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MartinWitt !

@slarse slarse merged commit 2357619 into INRIA:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@slarse slarse slarse approved these changes

@I-Al-Istannen I-Al-Istannen I-Al-Istannen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWitt @SirYwell @slarse @I-Al-Istannen