feat(process): Allows interruption of a processor. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| package spoon.processing; | ||
|
|
||
| public class ProcessInterrupt extends RuntimeException { |
There was a problem hiding this comment.
rename to InterruptProcess?
There was a problem hiding this comment.
I have chosen the name specified in the issue but I can change it. A better solution can be InterruptProcessException.
There was a problem hiding this comment.
ProcessInterruption
|
Adds documentation in the website. |
| for (CtElement e : new ArrayList<CtElement>(elements)) { | ||
| process(e, p); | ||
| } | ||
| p.processingDone(); |
There was a problem hiding this comment.
If ProcessInterrupt is thrown in processingDone the method processingDone will be called two times.
|
@monperrus PR ok. |
| @@ -19,7 +19,8 @@ of the processor class. There is also an optional overridable method for queryin | |||
| elements at a finer grain. | |||
|
|
|||
| The process method takes the requested element as input and does the analysis | |||
| (here detecting empty catch blocks). | |||
| (here detecting empty catch blocks). At any time, you can interrupt the processing | |||
| of your processor with the call of `interrupt()` method. | |||
There was a problem hiding this comment.
At any time, you can interrupt the processing of the model with a call to interrupt() (this stops all processors, and proceeds with the next step which is usually pretty-printing the code to disk).
|
@monperrus PR ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478