fix: records can have static initializers #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
changed the title
MartinWitt
requested changes
Oct 16, 2022
Comment on lines
+211
to
+217
| void testBuildRecordModelWithStaticInitializer() { | ||
| // contract: a record can have static initializers | ||
| String code = "src/test/resources/records/WithStaticInitializer.java"; | ||
| CtModel model = assertDoesNotThrow(() -> createModelFromPath(code)); | ||
| List<CtAnonymousExecutable> execs = model.getElements(new TypeFilter<>(CtAnonymousExecutable.class)); | ||
| assertThat(execs.size(), equalTo(2)); | ||
| } |
There was a problem hiding this comment.
Maybe use ModelTest here?
There was a problem hiding this comment.
As building the model failed, we can't use ModelTest here
| if (member instanceof CtAnonymousExecutable) { | ||
| JLSViolation.throwIfSyntaxErrorsAreNotIgnored(this, "Anonymous executable is not allowed in a record"); | ||
| if (member instanceof CtAnonymousExecutable && !member.isStatic()) { | ||
| JLSViolation.throwIfSyntaxErrorsAreNotIgnored(this, "Instance initializer is not allowed in a record"); |
There was a problem hiding this comment.
An oversight from myself earlier, we should add the JLS paragraph here. Could you add it?
MartinWitt
approved these changes
Oct 17, 2022
|
Impressive high speed at fixing issues, thank @SirYwell. Will merge later today/tomorrow after the 24-hour period. If I forgot to merge it, feel free to ping me. |
MartinWitt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4961
While instance initializers are forbidden, static initializers are allowed.