-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct spelling mistake in API, doc and tests (#5934) #5943
fix: correct spelling mistake in API, doc and tests (#5934) #5943
Conversation
PinkMoustacheMan
commented
Aug 20, 2024
- mark misspelled method as deprecated
- add new method with correct spelling
- correct spelling of method in docs and test classes
- mark misspelled method as deprecated - add new method with correct spelling - correct spelling of method in docs and test classes
thanks for the PR. would you have a look at the failing CI job? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the method added to the interface be default
and delegate to the deprecated method to avoid breaking changes?
I believe it should be the other way around. |
Per the theory of software engineering, there should be no delegation:
Here, the code is so simple, so I'm happy to merge anyway when CI is green. |
- add missing javadoc properties - change indentation from spaces to tabs
7ea0ad7
to
b49327c
Compare
I do agree with the notion that deprecated methods should not change anymore, so I reverted that change. |
Thanks. Why do we have a public and a private version of the same method AFAIU? see |
There is a public |
thanks a lot @PinkMoustacheMan |