Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized missing column for computed score #25

Closed
adilger opened this issue Jul 19, 2020 · 4 comments
Closed

Customized missing column for computed score #25

adilger opened this issue Jul 19, 2020 · 4 comments

Comments

@adilger
Copy link
Collaborator

adilger commented Jul 19, 2020

I was using the custom field display, and it appears that there is no column showing the computed score for the results:

Screen Shot 2020-07-18 at 19 10 23

This makes it hard to compare beyond the ordering based on the score.

Not a critical issue, but something to fix when you get a chance.

@jeanbez
Copy link
Contributor

jeanbez commented Jul 25, 2020

@adilger this has been fixed in the jbez mirror. Could you please try again?

@adilger
Copy link
Collaborator Author

adilger commented Jul 28, 2020

Jean, thanks for the update. I see the custom score now.

One thing that this now exposes is that the value of the custom equation is not being calculated correctly in all cases.

For example, if the divisor is zero because the fields are unset then it appears to be using the fields from the previous entry in the list:
io500-custom

In the Shaheen case, the divisor is 4, which also appears to be the value from the previous entry in the list.

It isn't clear to me whether the calculated result should be "infinity" in this case, and ranked at the top of the list, or if it should be excluded completely? In the VI4IO ranking, I was able to multiply the zero in the numerator, so the result was zero before dividing by zero (NaN) which ranked at the end of the list. It would be nice to have a checkbox like "exclude invalid results" (i.e. Inf and NaN), or allow booleans like "( information_ds_nodes + information_md_nodes > 0 ) *" so the result is multiplied by 0 if the expression isn't true.

@johnbent
Copy link
Contributor

johnbent commented Aug 7, 2020

@jeanbez looks like Andreas has a request here so we can't close this one yet maybe?

@adilger
Copy link
Collaborator Author

adilger commented Nov 19, 2020

Closing this issue, since the original issue was addressed. I've opened issue #73 to track the second issue.

@adilger adilger closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants