Notes about refactoring OAI exports for testability.

This needs some sophisticated refactoring to be ready for unit tests.

src/main/java/edu/harvard/iq/dataverse/DatasetServiceBean.java

@@ -574,6 +574,8 @@ public void exportAllAsync() {
     /**
      * Scheduled function triggering the export of all local & published datasets,
      * but only on the node which is configured as master timer.
+     *
+     * TODO: this is not unit testable as long as dependent functions aren't.
      */
     @Lock(LockType.READ)
     @Schedule(hour = "2", persistent = false)
@@ -584,6 +586,18 @@ public void exportAll() {
         }
     }
 
+    /**
+     * TODO: this code needs refactoring to be unit testable:
+     *       1) Move the Logger/FileHandler stuff to a factory in a Service
+     *          (Export or Logging service) a) to make it mockable and
+     *          b) to have common, reusable code.
+     *       2) Move this to OAIRecordServiceBean. The additional pieces for a
+     *          complete OAI export is in OAISetServiceBean, so it makes more
+     *          sense to live there and use this service as a service.
+     *       3) Moving this to OAIRecordServiceBean makes findAllLocalDatasetIds(), etc
+     *          mockable, so this class (DatasetServiceBean) does not need immediate action.
+     * @param forceReExport
+     */
     public void exportAllDatasets(boolean forceReExport) {
         Integer countAll = 0;
         Integer countSuccess = 0;

src/main/java/edu/harvard/iq/dataverse/harvest/server/OAIRecordServiceBean.java

@@ -225,8 +225,13 @@ public void markOaiRecordsAsRemoved(Collection<OAIRecord> records, Date updateTi
     // (why these need to be in an EJB bean at all, what's wrong with keeping 
     // them in the loadable ExportService? - since we need to modify the 
     // "last export" timestamp on the dataset, being able to do that in the 
-    // @EJB context is convenient. 
+    // @EJB context is convenient.
 
+    /**
+     * TODO: This should be refactored to be the scheduled export routine.
+     *       See DatasetServiceBean.exportAllDatasets().
+     *       This should use an Export service as EJB to get things mockable.
+     */
     public void exportAllFormats(Dataset dataset) {
         try {
             ExportService exportServiceInstance = ExportService.getInstance(settingsService);

src/main/java/edu/harvard/iq/dataverse/harvest/server/OAISetServiceBean.java

@@ -186,6 +186,11 @@ public void exportOaiSet(OAISet oaiSet, Logger exportLogger) {
     /**
      * Scheduled export of all local & published datasets for OAI interface harvesting.
      * Only runs on the node configured as timer master.
+     *
+     * TODO: this code needs refactoring to be unit testable:
+     *       Move the Logger/FileHandler stuff to a factory in a Service
+     *       (Export or Logging service) a) to make it mockable and
+     *       b) to have common, reusable code.
      */
     @Lock(LockType.READ)
     @Schedule(hour = "2", persistent = false)