Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit File Metadata: Select All Files in Tab, Can't Edit Them All after clicking Edit Metadata #2859

Closed
eaquigley opened this issue Jan 12, 2016 · 2 comments
Assignees
Labels
Feature: File Upload & Handling Type: Bug a defect User Role: Curator Curates and reviews datasets, manages permissions

Comments

@eaquigley
Copy link
Contributor

eaquigley commented Jan 12, 2016

Seen by @sbarbosadataverse and me today on production.

We scrolled all the way through the files in the file tab, selecting all of them individually. We then clicked Edit Metadata and only 50 of the 66 files were available for editing. It seems like you cannot continuously scroll in the Primefaces component when on the edit page like you can on the view page.

@mheppler mheppler added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Feb 1, 2016
@pdurbin pdurbin added User Role: Curator Curates and reviews datasets, manages permissions and removed zEffort 1: Small labels Jul 4, 2017
@mheppler
Copy link
Contributor

mheppler commented Feb 6, 2018

Related to File Download: Changing the list of selected files for a multipage file list results in bad download all behavior. #3711, as well as to Initial ADA check: Primeface hidden checkboxes fail compatibility #2634. Investigate as part of Spike: Files DataTable, Selection, Paginator vs Scroll #4437.

@mheppler
Copy link
Contributor

Issue #4656, which removed the scrolling feature of the files table, was recently merged as part of 4.9.2. I tried to replicate this issue on demo, with a dataset containing 59 files. I was able to individually select all 59 files, and when I clicked Edit Files > Metadata, the Edit Files pg displayed all 59 files.

Also, as part of #4656 a new dynamic counter and "Select all ## files in this dataset" text link was added to the top of the files table. This will help you know exactly how files have selected currently. Which comes in very handy as it pertains to the use case reported in this issue.

I suggest that we can close this issue. Will assign to QA and tag @kcondon to confirm and close.

@mheppler mheppler added Status: QA and removed UX & UI: Design This issue needs input on the design of the UI and from the product owner labels Aug 27, 2018
@kcondon kcondon self-assigned this Aug 28, 2018
@kcondon kcondon closed this as completed Aug 28, 2018
@djbrooke djbrooke added this to the 4.9.2 - Stata Upgrades, etc. milestone Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Type: Bug a defect User Role: Curator Curates and reviews datasets, manages permissions
Projects
None yet
Development

No branches or pull requests

5 participants