Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset - File UI Improvements #3404

Open
mheppler opened this issue Oct 10, 2016 · 14 comments

Comments

@mheppler
Copy link
Contributor

commented Oct 10, 2016

There have been many suggested features and reported bugs with relation to the display of files on the dataset pg. These mockups have been created for many new features, including facets and sorting to improve browsing.

The scope of this issue will cover all the new UI improvements needed for the dataset pg. Rather than tracking nearly a dozen other issues, they'll be closed in favor of this one.

Mockup

dataset-files

Consolidated Issues

  • Better handling of dataset page with many files #2021
  • Dataset Files: Selecting files in files tab is problematic can result in mistakes (delete, download, edit, etc). #2023
  • Request Access for Files: Admin View Usability Issues #2285
  • Use Solr for file listing on dataset page #2455
  • Dataset Page: File Tab Sort Button #2506
  • Dataset Page File Tab: Add Facets #2508
  • Page printing: Messy printing of dataset #2584
  • Dataset: Select > Edit Files > Delete, large number of files, page does not refresh #2591
  • Files Tab: File count does not indicate how many files are currently displayed from total. #2681
  • Dataset Files - DataTable LiveScroll w/ Duplicate Files #2699
  • Dataset Files Table: Table Tries to Load More Files, When There Are No More #2701
  • Add "View All" button for files on the dataset page #2705
  • Files Tab: Tabular data tags are not sorted. #2808
  • data files scrolling: users report Chrome not allowing to scroll past 25-50 files #2835
  • File Page: Add Back to Top Option at Bottom of Page #2923
  • sorting file by downloads: feature request by user from HKS #2947
  • Request Access: According to mockups, there should be a request access popup. #2552
  • Dataset Page: Download button for tabular file has dropdown but is cut off if near the bottom of the list of files #3835
  • Dataset Page: Should lazy load thumbnails to better support slower storage media and improve page responsiveness. #4091
  • Dataset Page HTML cleanup (W3 validator errors) #3750

These are related issues, which will remain open in order to track development of other projects which will impact this project.

Related Issues

  • Dataset: File Hierarchy + Directory Structure #2249
  • Initial ADA check: Primeface hidden checkboxes fail compatibility #2634
  • Download Permissions: Remove business logic from Application fragments. #2698
  • Edit File Metadata: Select All Files in Tab, Can't Edit Them All after clicking Edit Metadata #2859
  • UI Cleanup - Action Button + Metrics Block Layout #3341
  • Download button present for files in previous dataset versions when newest version is restricted #3576
  • Performance degradation investigation #3631
  • File Download: Changing the list of selected files for a multipage file list results in bad download all behavior. #3711
  • Improve visibility of buttons for data owners #3815
  • UI to enable file tags to be searched #4122
  • Dataset page: Page fails to load when it cannot understand an image file to generate thumbnail #4473
  • Long (e.g. SHA-512) fixity checksums are too long for display #5210

@mheppler mheppler self-assigned this Oct 10, 2016

@amberleahey

This comment has been minimized.

Copy link

commented May 4, 2017

Hi there, just wondering will file organization on the dataset landing pages be supported in a future release? We have had a few members interested in this for a while now as currently the pages get cluttered and disorganized quite easily when many files are uploaded. Some even contain hundreds of files and when this happens it is not easily accessible for people to get at or understand any structure. Thanks for considering this for a future release, btw really like the mockup!

@pdurbin

This comment has been minimized.

Copy link
Member

commented May 15, 2017

@amberleahey do you have any sketches of how you'd like the file organization to look? Or maybe you can point us to a webapp that does this well.

@amberleahey

This comment has been minimized.

Copy link

commented May 16, 2017

the mock-up you have looks pretty nice for organization, but perhaps you could also add folder hierarchy or some structure to this? In some cases, we've had requests for this at the file level to support types of files, hierarchy of files, etc. It's difficult currently for files with more than 10 files, so anything will help! Thanks again maybe we will look into developing some mock-ups to support this development work.

@TaniaSchlatter

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

@amberleahey Thanks for adding your comments. I agree that it makes sense to work the requests for file organization/hierarchy into these other file UI improvements that have been mocked up. We don't have a plan to address these in the next sprint, but continued requests for these refinements should help them get prioritized.

@TaniaSchlatter

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

Note that the UI changes related to the citation block shown on this mock up are obsolete.

@dconner3

This comment has been minimized.

Copy link

commented Oct 11, 2018

Hello. We are using the "Request Access" button on a restricted file, but the emails we receive does not tell us who the requester was.

It seems like this ticket (as well as two preceding tickets (#1476, #2552) were going to try an address this issue. Is there any update?

More on our use case:
Without being able to follow up with individual requesters, all we get out of using the button is that there is interest in the restricted file. We plan on making it public eventually, but for now it needs to be embargoed. We want to give access to individual requestors, but the "Request Access" button does not give us the information we need to do that.

@mheppler

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

@dconner3 it seems like your use case relates to two issues that currently in progress.

  • Guestbook - Enabled for Request File Access #2043
  • Embargo: I want to set an embargo period to control when my data will be accessible. #4052

The embrago issue is still in the design phase of our development process. If you would like to add more information to that issue, we welcome the input to inform our designs.

The guestbook form for the request access workflow issue sounds like it is more related to your use case. That issue is being contributed by community developers from the good folks at ADA, including @stevenmce. You can add your input to that issue to tracking the progress of that feature going forward.

@pdurbin

This comment has been minimized.

Copy link
Member

commented Oct 12, 2018

@dconner3 I agree with what @mheppler is saying but if the email doesn't show the email address of the person who clicked "Request Access", please open a new issue about this with a screenshot, if possible. I wanted to point out that even if the email doesn't say who clicked "Request Access" which, again, would be a bug), the email should link you to the dataset and from the web interface you should be able to see the email address of the person who requested the file. For example, "pdurbin3@mailinator.com" would be the person who clicked "Request Access" in the screenshots below, which I can see by clicking "Edit" then "Permissions" then "File" like this:

screen shot 2018-10-11 at 8 50 18 pm

screen shot 2018-10-11 at 8 50 38 pm

screen shot 2018-10-11 at 9 00 35 pm

For some reason, I didn't receive the email from the server I tested on which is why I'm hoping you can create a new issue with a screenshot. I hope the workaround of looking in the web interface for the email address of the person who clicked "Request Access" helps. The idea is that you could email them on the side and ask more questions about why they want access.

@mheppler

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2018

Thanks for jumping in @pdurbin with some more detail. Since I seemed to overlook the email portion of this use case, I did some more digging in our issues and found this open issue.

  • Permissions: Timestamp + user name in notifications/permissions pg for access requests #2855

@dconner3 if that issue covers the problem you are seeing, I would suggesting commenting there in order to track it's progress going forward. We recently added more context to contact emails (#1916), but it appears we did not add those same improvements to request access emails.

@pdurbin

This comment has been minimized.

Copy link
Member

commented Oct 13, 2018

For some reason, I didn't receive the email

Huh, I finally got the email about six hours ago. Screenshot below. Sure enough, there's no way to tell who requested the file, just like @dconner3 said. That's not great.

screen shot 2018-10-13 at 9 02 11 am

@dconner3 do you feel like creating an issue for this? The fix should be relatively straightforward.

@dconner3

This comment has been minimized.

Copy link

commented Oct 26, 2018

Sorry for falling off this thread. Thank you for the additional information @pdurbin on how to see who the requester is through the web interface. @pdurbin, it looks like you added a screenshot to #2855. You don't need me to open an additional issue do you?

@pdurbin

This comment has been minimized.

Copy link
Member

commented Oct 27, 2018

@dconner3 as long as you're fine with using #2855 to track the smaller chunk of providing a bit more information in the email, I'm fine with that.

The bigger feature is the whole "requestbook" concept in #2043. Please feel free to subscribe to both issues or create a new one if neither one quite captures what you want. Thanks!

@djbrooke

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Before we bring this to development, we need to

  • Review Dataset Button options for scalability
    We decided on button options for user testing. Any further changes
  • Is the checklist included here?
    Not in this round of testing. We should plan to support checklists, both of the sensitive data variety and for custom checklists developed for a specific installation.
  • Review File list in File Table for scalability
    We are comfortable entering usability testing with what we have
  • Determine Usability Testing strategy, scope, and plan
    We'll plan to test 5-10 people, with half being people familiar with dataverse and half not. @TaniaSchlatter will develop the user testing plan and @djbrooke and the team will help with recruitment and note taking. If needed, @djbrooke and perhaps @jggautier can run user tests as well.
  • Recruit for Usability Testing
  • Complete Usability Testing
  • Analyze and Implement Usability feedback
  • Implement front end code and ensure accessibility (before sprint or in sprint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.