Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor S3 credential provisioning #5733

Closed
poikilotherm opened this issue Apr 9, 2019 · 0 comments · Fixed by #8313
Closed

Refactor S3 credential provisioning #5733

poikilotherm opened this issue Apr 9, 2019 · 0 comments · Fixed by #8313

Comments

@poikilotherm
Copy link
Contributor

poikilotherm commented Apr 9, 2019 •
edited
Loading

In #5478 the configuration of Swift storage is pretty much streamlined to contain endpoint(s), access credentials and others in JVM options. This is very usefull when configuring for usage on K8s and similar.

Currently, a S3 storage endpoint can be configured via JVM options. For credentials, you need to create ~/.aws/credentials. (see http://guides.dataverse.org/en/4.12/installation/config.html#manually-set-up-credentials-file)

The code in S3AccessIO.java should be refactored to use a credentials provider chain to read from AWS profile files or retrieve secrets via MicroProfile Config API.
This was referenced Apr 9, 2019
Closed
Closed
@poikilotherm poikilotherm mentioned this issue Jun 18, 2019
Closed
@poikilotherm poikilotherm changed the title Refactor S3 driver options and credential provisioning Refactor S3 credential provisioning Dec 16, 2021
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 16, 2021
@poikilotherm
feat(s3): make static credentials for AWS S3 possible IQSS#5733
d038f85 
This change does not alter existing behaviour. Anyway with current
or future use of the ~/.aws profiles/credentials may continue to do so.
This is useful to serve traditional installations, testing with AWS CLI
etc.

Containerized installations profit from not having to generate the
AWS CLI specific files. Also testing gets easier by providing
credentials via env or system props.
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 16, 2021
@poikilotherm
docs(s3): add docs for S3 creds from MPCONFIG IQSS#5733
4dc4811
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 16, 2021
@poikilotherm
docs(s3): add docs for S3 creds from MPCONFIG IQSS#5733
082006e
@poikilotherm poikilotherm mentioned this issue Dec 16, 2021
Merged
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 16, 2021
@poikilotherm
docs(s3): splitting of MPCONFIG settings per @qqmyers's review IQSS#5733
71c7661
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 16, 2021
@poikilotherm
docs(s3): add release note as requested by @DJBrook for IQSS#5733
c3a1e21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5733 s3 cred chain poikilotherm/dataverse
1 participant
@poikilotherm