-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured dataverses not appearing #6439
Comments
Thanks @jmjamison for reporting, we'll work on this soon. |
I can replicate the bug where, for a newly created dataverse, its featured dataverses don't show up if it doesn't have a description. It's also the case for dataverses that have already been published. These dataverses don't have descriptions and their featured dataverses don't show up:
Since a bug in 4.18.1 is making affiliation a required field (#6430), I can't test how the affiliation field is involved in the featured dataverses not showing up in newly created dataverses (since now I can't create a dataverse without affiliation). But the bug doesn't seem to be affecting dataverses with no affiliation fields that are already published (before 4.18.1). These dataverses have no affiliations but do have descriptions, and their featured dataverses are still displayed: |
My apologies, team, for my mistaken commit directly to develop. It was a minor change, and I was trying to crank out a PR ASAP and failed to notice that I had not created a new branch. Anyhow. In the UI fixes included in #5615 to improve the responsive layout of the dataverse pg, the featured dataverse carousel was missed, which somehow resulted in the block not displaying on the page, despite being included in the source code. Just needed to add some @landreev peeked at these changes and (more or less) approved them in Slack. @kcondon I believe the affiliate was a red herring. But you do have to be on a sub-dataverse below root. Let me know if you have any questions about the test case. |
Works |
… responsive layout style classes [ref IQSS#6439]
4.18.1, featured dataverses not appearing unless there is something in the description field and the affiliation filed. If description field/affiliation are empty then there is a blank area where the featured dataverses would be.
The text was updated successfully, but these errors were encountered: