Upgrade to Payara 6.2024.6 - #10495
Merged
Merged
Conversation
poikilotherm
added
Component: Code Infrastructure
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
No longer necessary, as all necessary add-opens were added with 6.2023.10
With 6.2023.7 they removed fish.payara.api:payara-api from the BOM, only to reintroduce it with 6.2023.12. We can simply revert adding the version and rely on Maven to get the version from the Payara BOM.
We should avoid hardcoding the version into the link to avoid stale information.
No longer necessary as the required add-opens has been included in upstream
poikilotherm
force-pushed
the
10494-payara-6.2024.4
branch
from
April 16, 2024 06:31
ab41d06 to
222b326
Compare
poikilotherm
marked this pull request as ready for review
April 16, 2024 06:33
This comment has been minimized.
This comment has been minimized.
qqmyers
reviewed
Jun 20, 2024
| With this version of Dataverse, we encourage you to upgrade to version 6.2024.4. | ||
| This will address security issues accumulated since the release of 6.2023.8, which was required since Dataverse release 6.0. | ||
|
|
||
| If you are using GDCC containers, this upgrade is included when pulling new release images. |
Member
There was a problem hiding this comment.
Should note that the release instructions need to add the standard Payara update steps. With this one, I think copying the domain works fine, i.e. like the instructions for Dataverse 5.6 rather than from our 5->6 transition.
Contributor
Author
There was a problem hiding this comment.
As requested, I added the instructions. Feel free to take a look.
As of Dataverse 6.0 we use Jakarta EE 10. The version of these dependencies comes from the Payara BOM and this property has no longer any use. Removing it will avoid future confusion.
This comment has been minimized.
This comment has been minimized.
As requested by @qqmyers
This comment has been minimized.
This comment has been minimized.
qqmyers
approved these changes
Jun 21, 2024
qqmyers
left a comment
qqmyers
left a comment
Member
There was a problem hiding this comment.
Looks good - I questioned whether we need one step in upgrading. QA should test upgrading as well as new install.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
added a commit
that referenced
this pull request
Aug 22, 2024
The _CT_ version is not needed now that we have upgraded to Payara 6.2024.6 in #10495 which included this fix: payara/Payara#6550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade to Payara
6.2024.46.2024.6 to cumulative address security vulnerabilities as well as better container support.Which issue(s) this PR closes:
Special notes for your reviewer:
Not sure what we should test / tell people about migrating their domain.xml. I'm leaning towards take a fresh domain and transfer your changes to the domain.xml.
Suggestions on how to test this:
Usual testing. Try containers.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Yes. Forthcoming.
Additional documentation:
None yet