Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4334 dataporten provider #4341

Closed
wants to merge 2 commits into from
Closed

4334 dataporten provider #4341

wants to merge 2 commits into from

Conversation

xibriz
Copy link
Contributor

@xibriz xibriz commented Dec 4, 2017

connects to #4334 oauth dataporten

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 12.701% when pulling f8d9541 on uit-no:4334-dataporten-provider into 4648b6a on IQSS:develop.

pdurbin
pdurbin approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Congrats on getting scribejava/scribejava#805 merged already and thanks for mentioning this in the code.

@pdurbin pdurbin mentioned this pull request Dec 5, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 12.846% when pulling d05e944 on uit-no:4334-dataporten-provider into 2c2d9c8 on IQSS:develop.

@scolapasta
Copy link
Contributor

As we want this to be a plugin outside the core code (see #4383), closing this PR.

@scolapasta scolapasta closed this Dec 13, 2017
@pdurbin pdurbin mentioned this pull request Dec 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xibriz @coveralls @scolapasta @pdurbin