Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4398 - Fix display of Harvest Client in edit mode #4432

Merged
merged 3 commits into from
Feb 1, 2018

Conversation

sekmiller
Copy link
Contributor

also the day of the week array is zero-based.

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

  • Unit [tests][x] NA
  • Integration [tests][x]: None
  • Deployment requirements, [x]: None
  • Documentation NA
  • Merged latest from "develop" branch and resolved conflicts

also the day of the week array is zero-based.
Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 12.855% when pulling c0863b4 on 4398-save-harvest-sched-updates into ef6b5ac on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants