Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Glassfish Statefulsets for OpenShift Deployment #4626

Merged
merged 2 commits into from
Apr 30, 2018

Conversation

MichaelClifford
Copy link
Contributor

This pull requests modifies openshift.json as well as glassfish-setup.sh to set up a mulit-pod glassfish statefulset in OpenShift.

This pull request requires that the dataverse glassfish image be rebuilt to reflect changes made to the default configuration file as well as the glassfish install script. To test, before rebuilding the image, you can point to my docker image by changing line 149 in openshift.json to ""dockerImageRepository": "jcliffbu/glassboat:test2"

No other changes have been made to run dv on openshift:
oc new-project [name]
oc new-app openshift.json

Once you have started, you can access the application via the route generated by OpenShift once all pods are deployed. It does take a few minutes for the .war file to load before the application becomes accessible.

You can also scale the number of pods up or down by editing the yaml file from the OpenShift web console.

Related Issues

@coveralls
Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage remained the same at 13.367% when pulling 1324e39 on EC528-Dataverse-Scaling:4040-glassfish1 into c593125 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great first pass. At minimum we need to revert changes to the Perl installer (install) and changing to the version of default.config under "doc". We should switch to the default.config under "conf". I explained more in comments.

POSTGRES_PORT 5432
POSTGRES_DATABASE dvndb
POSTGRES_USER dvnapp
POSTGRES_PASSWORD secret
SOLR_LOCATION localhost:8983
SOLR_LOCATION dataverse-solr-service:8983
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/sphinx-guides/source/_static/util/default.config should not be updated because it's used in a downloadable example from the Dataverse Installation Guide. Can you please revert this back to how it looks in the "develop" branch? The file to update instead is conf/docker/dataverse-glassfish/default.config. We gave similar feedback in pull request #4599 so don't feel bad. I introduced a lot of this confusion in my hacky build.sh script but it has since been fixed up in 493badf (already in develop) to look for a more appropriate default.config file.

fi
fi


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landreev can you please look at all these changes to the installer and let us know what you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -84,7 +84,7 @@ my %CONFIG_DEFAULTS = (
'POSTGRES_USER', 'dvnapp',
'POSTGRES_PASSWORD', 'secret',

'SOLR_LOCATION', 'LOCAL',
'SOLR_LOCATION', 'dataverse-solr-service:8983',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this back to "LOCAL". This "dataverse-solr-service" business only makes sense for installations of Dataverse in OpenShift. We need normal installations on whatever hardware or VM to continue to work. You shouldn't need this change because it's included already in conf/docker/dataverse-glassfish/default.config, which you should switch to instead of the version in "doc", as I attempted to explain above.

pull request updates
@MichaelClifford
Copy link
Contributor Author

@pdurbin, Thanks for taking a look at this. Just made those changes.

@pdurbin pdurbin merged commit b50d4bd into IQSS:develop Apr 30, 2018
@pdurbin pdurbin mentioned this pull request May 25, 2018
@danmcp danmcp mentioned this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants