Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4669 schema dot org exporter #4673

Merged
merged 3 commits into from
May 18, 2018

Conversation

donsizemore
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

akio-sone and others added 2 commits May 15, 2018 12:56
try-with construct was applied to the issue concerning JsonReader's missing close() statement
@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage remained the same at 13.171% when pulling ca3c77c on OdumInstitute:4669-SchemaDotOrgExporter into 42014cb on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be standard try-with-resources. Approved. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants