6898 link all children of linked dv #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
approved these changes
Jun 12, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Jun 12, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A recent update to make indexing perform better inadvertently turned off the creation of links to the dataverse children of newly linked dataverses. In addition to fixing this bug, this PR adds more efficiency to the indexing of linked dataverses.
Which issue(s) this PR closes:
Closes #6898
Special notes for your reviewer:
In order to make indexing more efficient, in the case of linked dataverses, instead of reindexing all of the progeny of the linked dataverses, the solr docs of the descendants are edited.
Suggestions on how to test this:
Link a dataverse that has several generations of sub-dataverses and see that all are linked to the linking dataverse. Re-index a dataverse that is linked and has many object to see that the re-indexing happens efficiently
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?:
No
Additional documentation: None