7256 purge referencedata

[poikilotherm]

What this PR does / why we need it:
This is a first step to ease deployments by making parts of the installer unnecessary.

One step during install is loading the SQL script reference_data.sql. I'd replace it by Flyway migrations & callback actions.

That way, the database related script is streamlined with the other database operations plus bootstrapping gets easier (no more installing Python Postgres nor psql in containers necessary).

Which issue(s) this PR closes relates to:

Related to #7256 (closed, but that set the trigger)
Related to #5361 (this PR is only a partial solution, so don't close)

Special notes for your reviewer:
Nada.

Suggestions on how to test this:
Deploy a fresh installation and check if indexes and initial data are still present.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
I don't think so.

Additional documentation:
Nope.

[poikilotherm]

Hey @landreev @sekmiller @pdurbin I'd love some chatter on this, as you guys crafted the original script.

[poikilotherm]

I think this is ready for review. It's narrow scoped. More stuff about bootstrapping to come later.

[coveralls]

Coverage remained the same at 19.479% when pulling 422bc26 on poikilotherm:7256-purge-referencedata into fe9e24d on IQSS:develop.

[scolapasta]

could you explain the names of the two new files?

[landreev]

I noticed that you are adding a couple of comments to the V1__flyway_schema_baseline.sql. I'm just curious, why is it NOT causing a problem? - Is that because Flyway purposefully does not save the checksum for the baseline file?

[poikilotherm]

@scolapasta
Actually it's only one new with a to date unknown filename schema: afterMigrate__1-upsert-referenceData.sql.

This is simply a script executed every time after a successfull migration happened (so this will be executed everytime a new DB migration happens). Please see flyway callback docs for more details.

It will not cause trouble because precautions are in place to only insert data if the DB is empty (during bootstrap). In the future, more scripts can be added with incremented numbers.

The name of V5.1.1.3__7256-purge-referencedata.sql should be updated to reflect the recent 5.2 release, the files were created before that.

@landreev
No checksum magic here. The file content is simply ignored AFAIK when the migration is already applied. At least it has been ignored when I tried to insert indexes with it... (see fc3dbb6)

[scolapasta]

@poikilotherm ah gotcha. the 5.1.1.3 confused me. Can you update? And I had not head the term "upsert" before, so didn't know what that meant (now I do :)

[poikilotherm]

Sure!
So you folks think this is the way to go? Should we talk about it some more? Or just update and push to QA then?

[scolapasta]

Seems reasonable enough to me and I know @landreev took a look, as well. @poikilotherm if you feel it needs any more discussion, we can include as part of the Tuesday meeting.

[poikilotherm]

@scolapasta I updated the files.

I'll take the liberty to move to QA, as y'all were happy with code review. Please revert if any concerns arise with that.

[poikilotherm]

Thanks for merging @kcondon! 🥳