Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5345 Make EJB timers nonpersistent #7416

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Nov 17, 2020

What this PR does / why we need it:
As discussed in #5345, #7048, on IRC, Slack and Zoom plus this Google doc, we need to make the EJB timers non-persistent for enabling application-level database connection definitions.

Which issue(s) this PR closes:

Closes #5345

Special notes for your reviewer:

  • It might me an idea to add a Flyway migration dropping the unused EJB timer table from the DB.

Suggestions on how to test this:

  • Remember to reconfigure the EJB timer database (see release note)
  • Check if timers still work.
  • Check if timers still work on multi-instance installation without conflicting runs.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
Yeah, a small one about removing the EJB timer database configuration setting on the app server. 🔋 included.

Additional documentation:
This is a quick and dirty solution, not very sophisticated for future enhancements. At some point in the future, we need to come back to the ideas of the Google Doc.

@poikilotherm poikilotherm marked this pull request as ready for review November 17, 2020 17:06
@poikilotherm
Copy link
Contributor Author

poikilotherm commented Nov 17, 2020

Like I said @landreev the actual code change is pretty trivial (2 lines). The rest is cosmetic and doc changes.

@landreev we might think adding a Flyway migration that deletes the old database table.

@poikilotherm poikilotherm added this to the 5.3 milestone Nov 17, 2020
@coveralls
Copy link

coveralls commented Nov 17, 2020

Coverage Status

Coverage remained the same at 19.48% when pulling 67172d7 on poikilotherm:5345-nonpersistent-ejb-timers into 9cce13d on IQSS:develop.

@djbrooke djbrooke removed this from the 5.3 milestone Nov 17, 2020
Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdurbin @landreev and I all took a look and we're happy with this one.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Nov 20, 2020
@kcondon kcondon self-assigned this Nov 24, 2020
@kcondon kcondon merged commit ffaba33 into IQSS:develop Nov 24, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Nov 24, 2020
@poikilotherm
Copy link
Contributor Author

Woohooo!

🌟 Thanks for merging @kcondon !!! 🌟

@djbrooke djbrooke added this to the 5.3 milestone Nov 30, 2020
@poikilotherm poikilotherm deleted the 5345-nonpersistent-ejb-timers branch December 7, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Proposal: make persistent EJB timers non-persistent or not rely on database
5 participants