7398 saved search performance #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
reviewed
Dec 2, 2020
| @@ -60,31 +42,15 @@ | |||
|
|
|||
| public List<Dataverse> findLinkingDataverses(Long datasetId) { | |||
| List<Dataverse> retList = new ArrayList<>(); | |||
| for (DatasetLinkingDataverse dld : findDatasetLinkingDataverses(datasetId)) { | |||
| retList.add(dld.getLinkingDataverse()); | |||
| Query query = em.createQuery("select object(o) from DatasetLinkingDataverse as o where o.dataset.id =:datasetId order by o.id"); | |||
There was a problem hiding this comment.
Any reason this wasn't added as a named query?
There was a problem hiding this comment.
No, just because I was only changing the ones related specifically to saved search. I did think about it. And sure, I can add the others too, while I'm at it.
sekmiller
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds some optimization for saved searches and some code cleanup
Which issue(s) this PR closes:
None for sure - it may fix #7398if the performance is improved enough
Special notes for your reviewer:
While I was at it, I made some Named queries and did some cleanup.
Suggestions on how to test this:
just make sure saved searches work as expected. You could also compare the timing of how long it takes to update a saved search before and after. (I will be doing some timing test with prod once released)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: