Fixed accessible input labels on add dv form [ref #7566] #7599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheppler
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
reviewed
Feb 10, 2021
| @@ -61,14 +61,14 @@ | |||
| <!-- Edit Info Panel --> | |||
| <div class="row" jsf:rendered="#{DataversePage.ownerId != null}"> | |||
| <div class="col-md-6 form-group"> | |||
| <h:outputLabel for="#{DataversePage.editMode == 'CREATE' ? 'selectHostDataverse' : 'hostDataverseStatic'}" styleClass="control-label"> | |||
There was a problem hiding this comment.
@mheppler out of curiosity, what did this h-> p change?
(the one below changes the "for" to an "id" - should that have happened here?)
There was a problem hiding this comment.
PrimeFaces form inputs have the crazy dynamic ID hierarchy (e.g. dataverseForm:selectHostDataverse) and you need a special PrimeFaces outputLabel component as compared to the basic JSF h: version in order for the labels and input components to be able to reference one another using their ID's. The input is properly reference in this basic JSF outputLabel, but it can't find the special PrimeFaces autoComplete component in the form.
scolapasta
approved these changes
Feb 10, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Feb 10, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed accessible input labels on add dv form. Screenreaders and accessiblity reports from tools like SiteImprove will notice that the form inputs for Host Dataverse and Email were missing proper associations to machine readable labels.
Also fixed missing label in the Contact Support popup form.
Which issue(s) this PR closes:
Closes #7566 Accessibility - missing form labels on "Add Dataverse" page
Special notes for your reviewer:
Suggestions on how to test this:
Can view accessibility reports for the Add Dataverse pg using the Chrome extension for SiteImprove. (See screenshot in #7566.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: