-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility - missing form labels on "Add Dataverse" page #7566
Comments
Thanks @kaitlinnewson, we'll take a look |
Was able to identify the missing input labels looking at demo (5.3) using the SiteImprove extension tool for Chrome. In addition to the Host Dataverse and Email form inputs, there were "no description" errors reported for the Browse/Search Facets picklist, as well as the Contact Support popup form linked from the navbar. I was able to fix the contact popup, but there appears to be an issue with the PrimeFaces picklist component, as it does not properly reference the labels associated with "hidden-accessible" form input dynamically created. This will need to be revisited when we next update PrimeFaces. |
Fixed accessible input labels on add dv form [ref #7566]
Hi IQSS team,
This issue was tested on Harvard Dataverse (5.3) and on Scholars Portal Dataverse (5.1.1).
On the "Add Dataverse" page, there are two form fields that don't have the labels properly associated with them: "Host Dataverse" and "Email".
For "Host Dataverse", the label is set to
for=dataverseForm:selectHostDataverse
, but the input id isdataverseForm:selectHostDataverse_input
(the proper id seems to be on the span element).For "Email", the label is set to
for=dataverseForm:contactEmail
, but the input id isdataverseForm:j_idt265:0:contactEmail
.The text was updated successfully, but these errors were encountered: