Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7565 update oncomplete #8627

Merged
merged 9 commits into from
Apr 22, 2022
Merged

7565 update oncomplete #8627

merged 9 commits into from
Apr 22, 2022

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it: removes the rebind update that was on almost all of the button in the app

Which issue(s) this PR closes:

Closes #7565

Special notes for your reviewer:

Suggestions on how to test this: there are no functional changes to the app, test is same as the previous pilot PR

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@scolapasta scolapasta self-assigned this Apr 20, 2022
@kcondon kcondon assigned kcondon and unassigned scolapasta Apr 21, 2022
@kcondon
Copy link
Contributor

kcondon commented Apr 21, 2022

Issues found:

  1. Harvest client failure, null ptr license [Update: this exists in v5.10.1]
  2. Creating a template fails with toa validation error also on editing and saving existing template
  3. Enabling/disabling guestbook throws tika zero byte file exception in log but works.
  4. Editing terms of existing template throws licensing error: javax.el.ELException: /dataset-license-terms.xhtml @328,156 disabled="#{!DatasetPage.isHasRestrictedFiles()}": java.lang.NullPointerException
  5. Seeing this in log file, may be related to recent toa merge: [2022-04-21T19:55:16.768+0000] [Payara 5.2021.5] [WARNING] [] [edu.harvard.iq.dataverse.util.BundleUtil] [tid: _ThreadID=95 _ThreadName=http-thread-pool::jk-connector(5)] [timeMillis: 1650570916768] [levelValue: 900] [[
    Could not find key "toua.invalid" in bundle file: ]]

@coveralls
Copy link

coveralls commented Apr 21, 2022

Coverage Status

Coverage decreased (-0.0008%) to 18.972% when pulling 512c8d9 on 7565-update-oncomplete into b864d1a on develop.

@sekmiller sekmiller assigned sekmiller and unassigned kcondon Apr 22, 2022
@sekmiller sekmiller assigned kcondon and unassigned sekmiller Apr 22, 2022
@kcondon kcondon merged commit 92a14a8 into develop Apr 22, 2022
@kcondon kcondon deleted the 7565-update-oncomplete branch April 22, 2022 20:01
@pdurbin pdurbin added this to the 5.11 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve (simplify) Primefaces (Ajax) / Bootstrap interaction
5 participants