TDL/7493 improve bag generator failure handling part 2 #8773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gnerator_failure_handling
Merged
…Gnerator_failure_handling
…Gnerator_failure_handling
|
As with other resources not getting released issues, aside from regression testing in the all-good case, the only way to see the problem and that the PR improves things is to configure an error. In this case, one way to cause the file-retrieval HTTP calls (done when creating the archival bag) to fail is to remove the physical files in a dataset you archive (how we discovered the issue at TDL and verified that this fix helps - some old test datasets did not have physical files) but any way of causing file retrieval API calls to fail would work (e.g. using a proxy of some sort.) As I noted in the test instructions though, I'm not sure how much effort on the failure cases in QA makes sense - deleting some test files might be simple enough. |
…Gnerator_failure_handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It looks like a merge with develop after other PRs in the original #8609 PR undid the changes that were supposed to be in the PR. This PR reapplies those and adds a bug fix for the checksum validation that is done when using the local archiver (the paths to find the files in the validator were not updated when the RDA work added a top-level dir within the bag structure.)
Which issue(s) this PR closes:
Closes
Special notes for your reviewer: Argh - I messed up in breaking the 3A work into PRs. Nominally the main changes here were reviewed before. The only addition is passing the bagName to the BagValidationJob class since the bag now has paths like doi-10-5072-fk2abcdef/data/filepathname and the manifest only includes the data/filepathname part.
Suggestions on how to test this: From the #8603 issue - the fix is primarily about avoiding hung connections in cases where physical files are missing. Not sure how far to go in trying to test that, but minimally this should be regression tested (i.e. in the normal case, archival bags are still produced with the local archiver, etc. Similarly in the normal case, there shouldn't be any waring/sever messages from the BagValidationJob class when using the local archiver.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: part of #8611
Additional documentation: