Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate one assay table per assay type #369

Closed
Zigur opened this issue Nov 9, 2020 · 1 comment
Closed

Generate one assay table per assay type #369

Zigur opened this issue Nov 9, 2020 · 1 comment
Assignees
@Zigur
Labels
create enhancement
Milestone
0.12

Comments

@Zigur
Copy link
Contributor

Zigur commented Nov 9, 2020

At the moment one Assay is generated per assay type for each StudyCell in the study designed.
Ideally, one Assay per assay type (as specified in the study design) should be created.

This will require reworking StudyDesign._generate_samples() (https://github.com/ISA-tools/isa-api/blob/develop/isatools/create/models.py#L2079), which actually generates both samples and their whole process sequence.
@Zigur Zigur added this to the 0.12 milestone Nov 9, 2020
@Zigur Zigur self-assigned this Nov 9, 2020
Zigur added a commit that referenced this issue Nov 11, 2020
@Zigur
groupings assays by assay type #369 (tests WIP)
e2cada1
Zigur added a commit that referenced this issue Nov 12, 2020
@Zigur
removing unused argument; tests wip #369
c9f81d7
Zigur added a commit that referenced this issue Nov 12, 2020
@Zigur
tests work fix #369
6140f9e
@Zigur
Copy link
Contributor Author

Zigur commented Nov 12, 2020

This should be completed now

@Zigur Zigur mentioned this issue Nov 12, 2020
Merged
@Zigur Zigur closed this as completed Nov 17, 2020
Zigur added a commit that referenced this issue Dec 15, 2020
@Zigur
Merge pull request #373 from ISA-tools/assay_improvements
75d864a 
Assay improvements - issues #369, #370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zigur Zigur

Labels
create enhancement
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
1 participant
@Zigur