Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform strings describing assay nodes #370

Closed
4 tasks done
Zigur opened this issue Nov 9, 2020 · 1 comment
Closed
4 tasks done

Uniform strings describing assay nodes #370

Zigur opened this issue Nov 9, 2020 · 1 comment
Assignees
Milestone

Comments

@Zigur
Copy link
Contributor

Zigur commented Nov 9, 2020

We want to apply the following changes to the assay node names:

  • The extract node will have the name: ASSAY{assay_index}-{start_node_index}-Extract{extract_index_within_subgraph} (e.g "ASSAY0-3-Extract1")
  • The labeled extract node will have the name: ASSAY{assay_index}-{start_node_index}-LE{labeled_extract_index_within_subgraph} (e.g "ASSAY0-3-LE1")
  • The protocol node will have the name: {technology type}_{cell name}_ASSAY{assay_index}-{start_node_index}-<data_acquisition>{protocol_index_within_subgraph} (e.g. "mass-spectrometry_A0E2_ASSAY0-3-<data_acquisition>1")
  • The raw data file: {file type}_{cell name}_ASSAY{assay_index}-{start_node_index}-{file__index_within_subgraph} (e.g. "raw-spectral-data-file_A0E2_ASSAY0-3-1")

In practice, this requires to keep a counter by type (extract, labelled extract, protocol, raw data file) of the subgraph nodes as they are created.

As per discussion:
https://isateam.slack.com/archives/D0J1PUY79/p1604319144023500?thread_ts=1604316967.014800&cid=D0J1PUY79

@Zigur Zigur added this to the 0.12 milestone Nov 9, 2020
@Zigur Zigur self-assigned this Nov 9, 2020
Zigur added a commit that referenced this issue Nov 17, 2020
Zigur added a commit that referenced this issue Nov 18, 2020
@Zigur
Copy link
Contributor Author

Zigur commented Nov 18, 2020

This works. The only difference with the specs is that <data_acquisition> has been changed to , as a protocol node could actually produce something else than a file as output in some configuration (at least potentially)

@Zigur Zigur closed this as completed Nov 18, 2020
Zigur added a commit that referenced this issue Nov 23, 2020
Zigur added a commit that referenced this issue Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant