Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in explicit conversion to string type. #402

Closed
wants to merge 1 commit into from

Conversation

J-81
Copy link

@J-81 J-81 commented Jun 29, 2021

Addresses issue when investigation identifier is interpreted by pandas as a numerical type and subsequently rejected when investigation identifier checks the type.

Addresses issue when investigation identifier is interpreted by pandas as a numerical type and subsequently rejected when investigation identifier checks the type.
Copy link
Contributor

@Zigur Zigur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just a couple of questions:

Why do you also make the conversion for title and description? Could these be numbers as well in your investigations?

Do you also have the same issue with study.identifier?

Zigur added a commit that referenced this pull request Jul 7, 2021
@proccaserra
Copy link
Member

this PR potential without a test on the input to the str() is unsafe.

TODO: add a condition to test that row['Investigation Identifier'] to check if undefined before applying the str() conversion.

in the absence of reply from @J-81 , one can assume that the same value may be passed to the other fields in that data source, hence requesting a similar treatment)

@terazus terazus closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants