Use vec_interleave()

[Robinlovelace]

See ropensci/stplanr#544

[JosiahParry]

I think using vctrs::vec_interleave() as you demonstrated will help speed this up quite a bit

[Robinlovelace]

Weird thing: I'm hitting an error message after switching to it, will double check...

[JosiahParry]

I think od returns a dataframe. Maybe you need to use vec_interleave() + as.data.frame()

[Robinlovelace]

That's what I've got:

od_coordinates_ids = function(odc) {
  res = vctrs::vec_interleave(odc[, 1:2], odc[, 3:4])
  res = data.frame(id = rep(1:nrow(odc), each = 2), x = res[, 1], y = res[, 2])
  res
}

[Robinlovelace]

It's something about NA values.

[Robinlovelace]

Previous one for reference:

od_coordinates_ids = function(odc) {
  res = data.frame(id = rep(1:nrow(odc), each = 2), x = NA, y = NA)
  ids_odd = seq(1, nrow(res), by = 2)
  ids_even = ids_odd + 1
  res[ids_odd, c("x", "y")] = odc[, 1:2]
  res[ids_even, c("x", "y")] = odc[, 3:4]
  res
}

[Robinlovelace]

Error:

   --- re-building ‘od.Rmd’ using rmarkdown
   
   Quitting from lines 326-327 [unnamed-chunk-20] (od.Rmd)
   Error: processing vignette 'od.Rmd' failed with diagnostics:
   NA value(s) in bounding box. Trying to plot empty geometries?

[Robinlovelace]

OK problem found: as you say, vctrs expects a matrix.