Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_ functions #14

Closed
9 tasks done
Robinlovelace opened this issue Mar 9, 2019 · 7 comments
Closed
9 tasks done

Add get_ functions #14

Robinlovelace opened this issue Mar 9, 2019 · 7 comments

Comments

@Robinlovelace
Copy link
Member

Robinlovelace commented Mar 9, 2019

Building on experience with stats19, get_() is a good function name prefix to clarify that you're about to get some data from the outside world. I suggest the following functions:

  • get_centroid() - already there, at least for 2011 Census MSOAs for England and Wales
  • get_od() - added in Add get_od() function #13
  • get_desire_lines() - added in Add get_od() function #13
  • get_pct_zones()
  • get_pct_centroids()
  • get_pct_lines()
  • get_pct_routes_fast()
  • get_pct_routes_quiet()
  • get_pct_rnet()

Just an idea for now and we don't have to do all of them, but I think it will make it much easier to get the valuable data provided by the PCT.

@layik
Copy link
Collaborator

layik commented Mar 9, 2019

This is what we are talking about! What a feast :)

@layik
Copy link
Collaborator

layik commented Mar 9, 2019

Some of them would need clarifications/assistance for an outsider like me.

@Robinlovelace
Copy link
Member Author

See latest commits: get_pct_zones() is in there. Building on the generic get_pct() function, the others should be quick to add.

layik added a commit that referenced this issue Mar 11, 2019
layik added a commit that referenced this issue Mar 11, 2019
@layik
Copy link
Collaborator

layik commented Mar 11, 2019

Wrapper functions, we can document get_pct and it can be used as the main function. If you are happy @Robinlovelace this can be closed.

@layik
Copy link
Collaborator

layik commented Mar 11, 2019

Not quire sure why travis is not happy with installing rgdal.

@Robinlovelace
Copy link
Member Author

We shouldn't need rgdal...

layik added a commit that referenced this issue Mar 11, 2019
@Robinlovelace
Copy link
Member Author

Awesome work @layik ! Seems done to me so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants