Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getting.rmd to include the schools road network #106

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

natesheehan
Copy link
Contributor

@natesheehan natesheehan commented Aug 24, 2021

@Robinlovelace a short paragraph and chunk of code for the schools road network

@Robinlovelace
Copy link
Member

Will take a look now...

Copy link
Member

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few issues here but can fix as post merge fixes to keep things moving. Great section 👍

@@ -190,7 +190,7 @@ If you have not already done so, you will need to install the R packages we will
```{r, message=FALSE}
library(pct)
library(sf) # key package for working with spatial vector data
library(dplyr) # in the tidyverse
library(tidyverse) # in the tidyverse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that's what's breaking actions. I agree it would make sense for people to load the whole tidyverse rather than just dplyr...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I changed this as we are now using the summarise_if function from tidyverse

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summarise_if is in dplyr. had to double check but this is pretty conclusive:

dplyr::summarise_if
#> function (.tbl, .predicate, .funs, ...) 
#> {
#>     lifecycle::signal_superseded("1.0.0", "summarise_if()", "across()")
#>     funs <- manip_if(.tbl, .predicate, .funs, enquo(.funs), caller_env(), 
#>         ..., .caller = "summarise_if")
#>     summarise(.tbl, !!!funs)
#> }
#> <bytecode: 0x558b932711a0>
#> <environment: namespace:dplyr>

Created on 2021-08-24 by the reprex package (v2.0.1)

@Robinlovelace Robinlovelace merged commit 2d75567 into itsleeds:master Aug 24, 2021
@natesheehan
Copy link
Contributor Author

natesheehan commented Aug 24, 2021

so it is - my bad! I think we can revert back to how things were as I have tested on my local branch, apologies for the mix-up!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants