The pct vignette is not reproducible #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue 79 (PCT vignettes not reproducible) - added geography label as MSOA to sort the mismatch between fetching centroid data. - Switched EVAL = FALSE to TRUE.
Update pct.Rmd
All PCT_*() downloads at the MSOA level
|
Yep, makes sense. I've added all |
|
Great work @natesheehan, I plan to do a few post-merge tidy-ups but overall this is looking great. Thanks 🎉 |
Robinlovelace
approved these changes
Nov 26, 2020
| @@ -127,7 +127,7 @@ The zones with higher cycling levels are in the more densely populated south of | |||
| Likewise, the following command downloads the desire lines for the Isle of Wight: | |||
|
|
|||
| ```{r get_pct_lines, eval=FALSE} | |||
There was a problem hiding this comment.
I think this should also evaluate, will fix post merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #79 (#79)
added geography label as MSOA to sort the mismatch between fetching centroid data
Switched EVAL = FALSE to TRUE