Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PCT-Method-UK-Cities #87

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

natesheehan
Copy link
Contributor

RE issue #78

@natesheehan
Copy link
Contributor Author

@Robinlovelace I've created a vignette based on the Cardiff example from issue #78, as well as Exeter and Plymouth. Let me know what you think and if it needs any revisions 🚲

@Robinlovelace
Copy link
Member

Just checking this @natesheehan, many thanks!

Copy link
Member

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is just what's needed, great work @natesheehan. Will merge and put in a PR for you to review the changes I suggest.

comment = "#>"
)
```
Where is cycle infrastructure most needed in UK cities? Such decisions will fundamentally change our built enviroment and support national initiatives to build a more sustainable future. With the mission of growing cycling, the PCT package is designed to provide transport planners, policymakers and academics with free tools to prioritise investments and interventions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest the following wording, but can tweak after the event:

 Where is cycle infrastructure most needed in UK cities? Clear answers can fundamentally change our built environment and support national initiatives to build a more sustainable future. With the aim of enabling cycling uptake, the PCT project provides transport planners, policymakers and academics with free tools to prioritise investments and interventions. 


We can now wrap the method we used for Cardiff into a function in order to compare the differences between the two cities.
```{r}
PCTMethodDevon <- function(la_name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package mostly uses equals assignment. Can do post-merge fix on this.


Nice! The plots indicate a spatial spread for cycling in Plymouth, with investment nessecary not only in the centre of the city. While for Exeter the distribution remains monocentric, with investment nessecary mostly in the centre.

#Conclusions and reccommendations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo but can be a quick fix.

@Robinlovelace Robinlovelace merged commit 883c029 into itsleeds:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants