Create Million_KMs-Cycled-Per-Year.rmd #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
natesheehan
commented
Dec 18, 2020
natesheehan
commented
- RE issue How to estimate million km cycled per zone? #59
- Rough first draft discussing how to calculate, compare and use the PCT models
- RE issue itsleeds#59 - Rough first draft discussing how to calculate, compare and use the PCT models
fixed map plots
more map styling
|
Thanks for this @natesheehan. I think there's an issue with vignette titles: |
Robinlovelace
requested changes
Dec 18, 2020
| title: "Estimating million km's cycled per zone in England and Wales regions" | ||
| output: rmarkdown::html_vignette | ||
| vignette: > | ||
| %\VignetteIndexEntry{Reproducing cycling potential estimates in UK cities} |
There was a problem hiding this comment.
This should be updated to: Estimating million km's cycled per zone in England and Wales regions
few text and map edits
|
Many thanks @natesheehan, looking good. It's still complaining about duplicate title, not 100% sure what it's going on about tbh or how to fix it... 2 options: I merge now and fix up on my branch or you give it another bash. You call! |
|
Hm let me try deleting this PR and creating a new one // if not have a go on your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.