Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If gesdd fails, automatically try gesvd #595

Closed
mtfishman opened this issue Mar 18, 2021 · 0 comments
Closed

If gesdd fails, automatically try gesvd #595

mtfishman opened this issue Mar 18, 2021 · 0 comments

Comments

@mtfishman
Copy link
Member

The "divide_and_conquer" SVD algorithm (LAPACK's gesdd) is currently the default. It is a good balance of speed, accuracy, and reliability. However, it can occasionally fail to converge. In those cases, I think we should catch it and automatically try gesvd (which would be a simple modification to the logic here: https://github.com/ITensor/NDTensors.jl/blob/v0.1.28/src/linearalgebra.jl#L137-L145).

Similar design in the C++ ITensor code: ITensor/ITensor#386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant