Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with nextFrameID #208

Merged
merged 1 commit into from
Jul 25, 2013
Merged

fix bug with nextFrameID #208

merged 1 commit into from
Jul 25, 2013

Conversation

FredGithub
Copy link
Contributor

Hello,

I had a problem with Sequence using the callback beforeNextFrameAnimatesIn. The problem occurs when using the pagination links : the nextFrameID variable don't have the good value (it has the value of currentFrameID). However, when using next and prev buttons, nextFrameID has the right value.

So i looked at the code and noticed self.nextFrameID is set in the next/prev buttons click handlers before the callback is called. But it isn't in the pagination handler. So i added it and it seems to work now

This is a one line change commit, so you might figure out quick if it's correct or not :)

Regards,
Fred

IanLunn added a commit that referenced this pull request Jul 25, 2013
fixed bug whereby nextFrameID doesn't update when using pagination
@IanLunn IanLunn merged commit f211825 into IanLunn:master Jul 25, 2013
@IanLunn
Copy link
Owner

IanLunn commented Jul 25, 2013

Thanks @FredGithub! 👍

@FredGithub
Copy link
Contributor Author

Great :) You're welcome!

@martinAnsty
Copy link
Contributor

Works great for this case, but there is still a similar bug where goTo() is called directly (nextFrameID is not correctly set).

Perhaps it makes more sense to set nextFrameID within the goTo() method?

@FredGithub
Copy link
Contributor Author

Agreed. But this is too big of a change for me to do, I'll leave that to the creator

@IanLunn
Copy link
Owner

IanLunn commented Aug 15, 2013

@FredGithub This is resolved now. @martinAnsty submitted a pull request and I made a few modifications elsewhere to tidy things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants