Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subprocess catch mkvmerge exit code 1 #263

Open
LightArrowsEXE opened this issue Feb 16, 2023 · 0 comments
Open

Make subprocess catch mkvmerge exit code 1 #263

LightArrowsEXE opened this issue Feb 16, 2023 · 0 comments

Comments

@LightArrowsEXE
Copy link
Contributor

LightArrowsEXE commented Feb 16, 2023

mkvmerge returns exit code 1 if a warning is thrown (see: docs). However, currently this forcibly halts the muxing in vardautomation, because it errors before it can actually output anything it appears (and consequently, no cleaning up can be run either).

There should be an additional check to catch the exit code, if possible, and let vardautomation know that it's a non-fatal error and it should otherwise continue (and maybe throw a warning if you want, such as the one stderr should return).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant