Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-base_utility/comparepasswords_issafe test fails on i386 #6987

Closed
sebastic opened this issue Mar 1, 2019 · 4 comments · Fixed by #6977
Closed

base-base_utility/comparepasswords_issafe test fails on i386 #6987

sebastic opened this issue Mar 1, 2019 · 4 comments · Fixed by #6977
Assignees
Labels
area/tests Unit and environment tests bug Something isn't working
Milestone

Comments

@sebastic
Copy link
Contributor

sebastic commented Mar 1, 2019

The Debian package build for 2.10.3 failed on i386 due to a test failure:

 99/101 Test  #64: base-base_utility/comparepasswords_issafe ...............................***Failed    1.45 sec
Running 1 test case...
/<<PKGBUILDDIR>>/test/base-utility.cpp(67): �[1;31;49merror: in "base_utility/comparepasswords_issafe": check 0.9 <= diff && diff <= 1.1 has failed�[0;39;49m

�[1;31;49m*** 1 failure is detected in the test module "Master Test Suite"
�[0;39;49m

Full buildlog

@Al2Klimov Al2Klimov self-assigned this Mar 1, 2019
@Al2Klimov
Copy link
Member

This have already been fixed by #6977.

@sebastic
Copy link
Contributor Author

sebastic commented Mar 1, 2019

Thanks, I'll add your change as patch to the Debian package.

@sebastic
Copy link
Contributor Author

sebastic commented Mar 1, 2019

This issue is hard to reproduce, only on my 4th try did I manage. The debug output I added shows:

duration1: 1095376.000000
duration2: 906042.000000
diff:      1.208968

Increasing the range may also be an option to fix this issue.

@dnsmichi
Copy link
Contributor

Didn't see this upfront, it only happened with many parallel builds on release day. Therefore the patch was incorporated into the packages as a new revision, and will be part of 2.10.4 / 2.11 later.

@dnsmichi dnsmichi added bug Something isn't working area/tests Unit and environment tests labels Mar 11, 2019
@dnsmichi dnsmichi added this to the 2.10.4 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit and environment tests bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants