Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialise date time with timezone offset #41

Closed
yhabteab opened this issue May 10, 2023 · 0 comments · Fixed by #42
Closed

Don't serialise date time with timezone offset #41

yhabteab opened this issue May 10, 2023 · 0 comments · Fixed by #42
Assignees
@yhabteab
Labels
bug Something isn't working
Milestone
0.1.1

Comments

@yhabteab
Copy link
Member

Currently we serialize the date time using Frequency::SERIALIZED_DATETIME_FORMAT which includes the timezone offset P. Timezone offset can change over time due to DST changes for example and would end up with wrong timezone offset in the database as it's shifted back/forward by 1 hour. Also, date time deserialized with this format would return timezone offset +00:00 instead of the abbreviated timezone name like UTC, when using DateTimeZone::getName().
@yhabteab yhabteab self-assigned this May 10, 2023
@yhabteab yhabteab added this to the 0.1.1 milestone May 10, 2023
@yhabteab yhabteab added the bug Something isn't working label May 10, 2023
@yhabteab yhabteab mentioned this issue May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhabteab yhabteab

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

Include timezone name in serialized datetime format Icinga/ipl-scheduler
1 participant
@yhabteab